Add helix fit covariance matrix to HYBRID output #344
+626
−588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Thanks to this PR, the covariance matrix obtained from the HYBRID KF fit is now stored in the TTTrack object, and a couple of histograms "resOverSigma*z0"plotting z0 resolution divided by the uncertainty in the z0 taken from this matrix have been added to L1TrackNtuplePlot.C .
In addition, the TTTrack object has been slightly tidied up. This clean up preserves backwards compatibility, so it should still be possible to read old datasets, but a couple of changes are needed to L1 trigger code.
Since the TTTrack function stubPtConsistency() was renamed chi2BendRed() some years ago, and this PR deletes the obsolete name, I've made a PR cms-sw#49565 to central CMSSW to change the few L1 trigger routines that have not changed to the new name.
Quantile based resolution plots have been enabled in L1TrackNTuplePlot.C for the d0. And also for the beam-constrained Pt and phi0.
PR validation:
No change in tracking performance.